Skip to content

Add forceConsole to ConsoleTransportOptions #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add forceConsole to ConsoleTransportOptions #2496

merged 1 commit into from
Aug 8, 2024

Conversation

@neilenns
Copy link
Contributor

@neilenns neilenns commented Aug 8, 2024

Fixes #2495

  • Add the new property to the type

I've used this locally and confirmed it resolves the TypeScript error and I see the logs in VSCode debugger as the original fix intended.

@neilenns neilenns mentioned this pull request Aug 8, 2024
Closed
DABH
DABH approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@DABH DABH merged commit 4ff0538 into winstonjs:master Aug 8, 2024
@MRdevX MRdevX mentioned this pull request Aug 29, 2024
Open
@saileshbro saileshbro mentioned this pull request Aug 30, 2024
Closed
@nejidevelops nejidevelops mentioned this pull request Aug 30, 2024
Open
@Hamza-Slama Hamza-Slama mentioned this pull request Aug 30, 2024
Open
@Pavel-Durov Pavel-Durov mentioned this pull request Aug 30, 2024
Closed
@fanibahar fanibahar mentioned this pull request Aug 30, 2024
Open
@nc-minh nc-minh mentioned this pull request Aug 30, 2024
Open
@drnachio drnachio mentioned this pull request Aug 30, 2024
Open
@jgrevich jgrevich mentioned this pull request Aug 30, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request Aug 30, 2024
Open
@mechanicalpete mechanicalpete mentioned this pull request Aug 30, 2024
Merged
@FlorentinTh FlorentinTh mentioned this pull request Aug 30, 2024
Open
@paladinmansouri paladinmansouri mentioned this pull request Aug 30, 2024
Open
@NickyMartinez NickyMartinez mentioned this pull request Aug 30, 2024
Open
@debarghyab debarghyab mentioned this pull request Aug 30, 2024
Open
@Dmitry-White Dmitry-White mentioned this pull request Aug 30, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Aug 30, 2024
Open
@itscharukadeshan itscharukadeshan mentioned this pull request Aug 31, 2024
Merged
@Ahim-Gillamore Ahim-Gillamore mentioned this pull request Aug 31, 2024
Merged
@AnushaSalian AnushaSalian mentioned this pull request Aug 31, 2024
Open
@ludeknovy ludeknovy mentioned this pull request Aug 31, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Aug 31, 2024
Open
@qdraw qdraw mentioned this pull request Sep 1, 2024
Closed
@drwho725 drwho725 mentioned this pull request Sep 1, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Sep 2, 2024
Open
@rish2497 rish2497 mentioned this pull request Sep 2, 2024
Open
@BuckinghamAJ BuckinghamAJ mentioned this pull request Oct 2, 2024
Merged
This was referenced Oct 2, 2024
Open
Open
Open
Open
@AnushaSalian AnushaSalian mentioned this pull request Oct 8, 2024
Open
@supriza supriza mentioned this pull request Oct 26, 2024
Closed
@nejidevelops nejidevelops mentioned this pull request Oct 27, 2024
Open
@rish2497 rish2497 mentioned this pull request Oct 27, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 27, 2024
Open
@fanibahar fanibahar mentioned this pull request Oct 29, 2024
Open
@m-heyda m-heyda mentioned this pull request Oct 31, 2024
Open
@nc-minh nc-minh mentioned this pull request Oct 31, 2024
Open
@paladinmansouri paladinmansouri mentioned this pull request Oct 31, 2024
Open
@BenjaminHoegh BenjaminHoegh mentioned this pull request Oct 31, 2024
Closed
This was referenced Nov 1, 2024
Open
Open
@drnachio drnachio mentioned this pull request Nov 2, 2024
Open
@debarghyab debarghyab mentioned this pull request Nov 3, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 4, 2024
Open
@Dmitry-White Dmitry-White mentioned this pull request Nov 5, 2024
Open
@AnushaSalian AnushaSalian mentioned this pull request Nov 5, 2024
Open
@cksachdev cksachdev mentioned this pull request Nov 7, 2024
Closed
@saileshbro saileshbro mentioned this pull request Nov 7, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Nov 11, 2024
Open
@nickvadala-snyk nickvadala-snyk mentioned this pull request Nov 11, 2024
Open
@rish2497 rish2497 mentioned this pull request Nov 11, 2024
Open
@fanibahar fanibahar mentioned this pull request Nov 12, 2024
Open
@Dmitry-White Dmitry-White mentioned this pull request Nov 12, 2024
Open
@paladinmansouri paladinmansouri mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DABH DABH DABH approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: forceConsole is missing from ConsoleTransportOptions type definition

2 participants

@neilenns @DABH