1491 custom log levels can be silent #2387
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1) * Bump rimraf from 3.0.2 to 5.0.5 (#2357) * Bump rimraf from 3.0.2 to 5.0.5 Bumps [rimraf](https://github.com/isaacs/rimraf) from 3.0.2 to 5.0.5. - [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md) - [Commits](isaacs/rimraf@v3.0.2...v5.0.5) --- updated-dependencies: - dependency-name: rimraf dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * fix: rimraf is not a function * fix: rimraf is not a function * fix: rimraf is not a function * fix: done() is not called on mocha hooks * fix: done() invoked with non-Error * fix: resolution method is overspecified --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @colors/colors packgae to 1.6.0 (#2353) * Bump actions/checkout from 3 to 4 (#2346) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump split2 from 4.1.0 to 4.2.0 (#2336) Bumps [split2](https://github.com/mcollina/split2) from 4.1.0 to 4.2.0. - [Release notes](https://github.com/mcollina/split2/releases) - [Commits](mcollina/split2@v4.1.0...v4.2.0) --- updated-dependencies: - dependency-name: split2 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 3.11.0 * Update dependencies * Remove nonexistent Logger methods from types * chore(README.md): adds documentation around coloring json formatted logs --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jack Nolddor <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Halsall <[email protected]> Co-authored-by: DABH <[email protected]> Co-authored-by: Phillip Huang <[email protected]> Co-authored-by: Alejandro Campos <[email protected]>
…jawa/winston into ckujawa-1491-custom-log-levels-can-be-silent
…-log-levels-can-be-silent
|
Forget my comment in the other PR, seems #2386 is still needed on my mac at least... |
|
@ckujawa I cleaned this up a bit but tests are failing (specifically the custom levels one), can you take a look and opine / revise / add tests as appropriate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed merge conflicts in #2366 and reopening here -- credit to @ckujawa
The referenced issue is #1491