Skip to content

Conversation

@windmemory
Copy link
Member

Fix #80

@windmemory windmemory requested a review from huan October 20, 2020 07:34
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan
Copy link
Member

huan commented Oct 26, 2020

Thank you very much for adding the grpc stream with FileBox to our hostie, it will greatly improve the stabilization of the service when we are dealing with big files!

Everything is good except that we should bump the minor version because it might introduce problems, so I update the version from v0.10 to v0.11.

@huan huan merged commit af4cd8e into master Oct 26, 2020
@windmemory windmemory deleted the use-stream branch October 26, 2020 09:36
@windmemory windmemory mentioned this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GRPC 传输大文件的时候会block掉其他的调用

2 participants