increase websocket connection timeout #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I think 1.5s is too short, and 10-30s maybe too long, so 5s looks better. |
AlbertShown
approved these changes
Jul 30, 2025
|
I set timeout to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current timeout failed many times on my pc, 5 seconds seems to be safer
Also if it fails, some times it segfaults at exit, seems like a double free somewhere, I tried following the trace with gdb but its not straight forward, you can reproduce if you make the time out 0 and try to open it many times
ref webui-dev/deno-webui#64 (comment)