Update setup script to download WebUI Github releases #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
commented
Sep 16, 2023
ttytm
force-pushed
the
build/download-prebuilts
branch
from
c42d6d4 to
fc9daca
Compare
|
That is a good idea, but I still need clarification about how other wrappers could download the pre-built binaries. Can you explain, please? |
|
Yep, I'll add a short explanation. It also should be possible to just attach it here or give a short instruction of how to compile it, if you prefer to have it self compiled. Then its possible to test how it would work. Maybe even creating the repo as private at first, then testing it is the full experience :D |
ttytm
force-pushed
the
build/download-prebuilts
branch
4 times, most recently
from
a289e9d to
b7cc4a3
Compare
ttytm
force-pushed
the
build/download-prebuilts
branch
from
b7cc4a3 to
fa4731c
Compare
|
We can already move towards using the pre-builts here. If and how to use a release-downloader for other wrappers we can decide over at the test repo 🙂👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Currently it uses WebUIs nightly releases.
Eventually (for the 2.4.0 release), it will be updated to to download the stable releases by default and optionally nightly releases.
@hassandraga we could make this into a repo (something like webui-release-downloader). It could have its own binary GitHub releases and work as CLI tool that other wrappers could download and use to download and prepare the WebUI static files for different platforms. It would help to keep things uniform. I would make the webui destination dir configurable via an argument then.