fix: remove onbeforeunload workaround #1611
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
The code that is removed here added a
beforeunload
event check in order to prevent the reload from happening if the page is already refreshing.However, it is not always the case that after
beforeunload
page will continue reloading, for two reasons at least:beforeunload
is cancelable, by specIn my case, there is an API that writes to
window.location
using a custom protocol.window.location
changes but the JS context is preserved, leavingwebpack-dev-server
incapacitated.This PR fixes that (and should also apply cleanly to the v2 branch).
Ref: #841
Ref: #544
Breaking Changes
N/A
Additional Info
N/A