[css-ruby] Add ruby-align tests #14498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR. |
|
Why is there no test run in the tasks? Log in Taskcluster shows "Identified 0 affected tests", and those in Travis CI also exited immediately after setting up the browsers. |
|
Also I'd really like to see better reftest reviewing tooling (see #14654), otherwise I feel kinda reluctant to review tens of new tests... |
|
These are manual tests, instead of reftests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports https://w3c.github.io/i18n-tests/results/css-ruby#ruby_align to WPT. Currently, the tests are manual tests, since we're unable to come up with a way to automate them.
The
-00X.htmltests are in horizontal writing mode, and-10X.htmltests are in vertical writing mode. Each test has two variants, long base and long annotation. Forspace-betweenandspace-aroundtests, there're variants for one Latin word and multiple Latin word as ruby bases/annotations./cc @r12a @himorin