Skip to content

Conversation

@tsmith023
Copy link
Collaborator

@tsmith023 tsmith023 commented Aug 15, 2025

  • Determine which stubs to use based on the protobuf version rather than grpcio version
  • Only ship with the smallest major available protobuf stubs to avoid runtime issues
  • Add protobuf-specific health stubs to replace grpcio-health-checking

Closes #1786

…han grpcio version

- Only ship with the smallest major available protobuf stubs to avoid runtime issues
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@tsmith023 tsmith023 requested a review from dirkkul August 15, 2025 18:49
@tsmith023 tsmith023 marked this pull request as ready for review August 15, 2025 18:49
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 requested a review from a team as a code owner August 18, 2025 10:10
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.26%. Comparing base (4c923da) to head (23ac23b).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
- Coverage   87.29%   87.26%   -0.03%     
==========================================
  Files         269      269              
  Lines       18735    18777      +42     
==========================================
+ Hits        16354    16386      +32     
- Misses       2381     2391      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmith023 tsmith023 merged commit c370bf5 into main Aug 18, 2025
57 checks passed
@tsmith023 tsmith023 deleted the chore/fix-protobuf-runtime-stub-incompatabilities branch August 18, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improper required dependencies in weaviate-client 4.16.7 for Python 3.13

5 participants