Skip to content

Conversation

@jfrancoa
Copy link
Contributor

@jfrancoa jfrancoa commented Aug 11, 2025

Also, add missing dimensions on the text2vec_transformers vectorizer methods used in the new syntax.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.27%. Comparing base (4c923da) to head (da16b8d).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...aviate/collections/classes/config_named_vectors.py 66.66% 1 Missing ⚠️
weaviate/collections/classes/config_vectorizers.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
- Coverage   87.29%   87.27%   -0.02%     
==========================================
  Files         269      269              
  Lines       18735    18757      +22     
==========================================
+ Hits        16354    16370      +16     
- Misses       2381     2387       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Also, add missing dimensions on the text2vec_transformers
vectorizer methods used in the new syntax.

Fixes also the pyright error:
  Type 'AnyUrl | None' is not assignable to type 'AnyHttpUrl | None'
@jfrancoa jfrancoa force-pushed the jose/add-missing-multivec-support branch from 083f688 to da16b8d Compare August 11, 2025 11:26
@jfrancoa jfrancoa requested review from dirkkul and tsmith023 August 11, 2025 11:43
@jfrancoa
Copy link
Contributor Author

NamedVectors and Vectorizer is deprecated and support for new modules will be added only on the new Vectors class, closing this.

@jfrancoa jfrancoa closed this Aug 11, 2025
@jfrancoa jfrancoa reopened this Aug 11, 2025
@jfrancoa jfrancoa merged commit 45a44c4 into main Aug 12, 2025
110 checks passed
@jfrancoa jfrancoa deleted the jose/add-missing-multivec-support branch August 12, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants