Fix for #8: make forward/backward compatible with tf-1.0.x. #16
Conversation
Add version checks/changes at fail points based on output of tf_upgrade_tool.py. Add Python 3.x compatibility.
|
@barryridge Thank you so much for your help! I think tensorflow/models now only works with TF 1.0 or later so, if |
|
@warmspringwinds You're most welcome! Thank you publishing such a nice package. I'm looking forward to adapting it for another dataset, but I haven't had time yet. I should have time to play with this again next week though, so I'll also look at adjusting the PR then and let you know. |
|
Apologies for the delay with this! Should be ready for merging now. |
|
@barryridge Great! Thank you so much! I am glad that you like it. I will merge once we switch to a new TF version soon. |
|
@warmspringwinds, FYI, I just noticed while playing around with this stuff yesterday that PR #7 by @ahundt actually incorporates all of these changes anyway and does a lot more besides, so my PR is actually redundant if you merge #7. |
…ibility Fix for warmspringwinds#8: make forward/backward compatible with tf-1.0.x. # Conflicts: # tf_image_segmentation/utils/tf_records.py
Also add tf version requirement line to README.
|
@barryridge I think |
|
@BrianOn99 Sorry, must have missed that one. Should be fixed now in latest commit. |
|
@barryridge Thanks for the prompt fix. |
Fix for #8 based on comments by @vijtad and @zhaozj89.
Add version checks/changes at fail points based on output of
tf_upgrade_tool.py.
Add Python 3.x compatibility.
Unsure if adding forward/backward compatibility like this is the
best approach for future maintainability. Please advise and/or
feel free to reject PR as appropriate.