Set HeaderExtensionsToNegotiate after negotiation #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
reviewed
Aug 21, 2025
|
Are there some existing WPT tests or should we add some? |
maitrungduc1410
pushed a commit
to maitrungduc1410/webrtc
that referenced
this pull request
Aug 30, 2025
This changes HeaderExtensionsToNegotiate to remember the result of the last negotiation. Corresponding spec change: w3c/webrtc-extensions#238 Bug: webrtc:439514253 Change-Id: I420b65f252398b1bb72d1938c48dc548ec18fd60 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/404946 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45493}
|
There are some existing WPT tests that need modification (because they test the previous behaviour). I'm looking into that. |
youennf
reviewed
Sep 11, 2025
index.html
Outdated
| <p>Set {{RTCRtpTransceiver/[[HeaderExtensionsToNegotiate]]}} to the | ||
| <p>If transceivers of the same kind exist in the current PeerConnection, | ||
| copy {{RTCRtpTransceiver/[[HeaderExtensionsToNegotiate]]}} from | ||
| the first such transceiver. |
There was a problem hiding this comment.
This is a bit vague, we could use how https://w3c.github.io/webrtc-pc/#dom-peerconnection-gettranseceivers is defining the list of transceivers.
There was a problem hiding this comment.
this RTCPeerConnection object's set of transceivers, in insertion order.
There was a problem hiding this comment.
I went with a reference to [=CollectTransceivers=], should be non-vague....
youennf
approved these changes
Sep 11, 2025
|
Note: Find an example header extension that has to be consistent for all media sections on a transport (BUNDLE). |
jan-ivar
reviewed
Sep 11, 2025
youennf
reviewed
Sep 11, 2025
| in a bundle, | ||
| and any other transceiver exists that will be included in the same bundle, | ||
| copy the {{RTCRtpHeaderExtensionCapability/direction}} attribute | ||
| for that extension from that other transceiver. |
There was a problem hiding this comment.
Maybe add an example to illustrate the usefulness of the mechanism
jan-ivar
approved these changes
Sep 11, 2025
I'm updating webrtc-extensions/RTCRtpTransceiver-headerExtensionControl with the new behaviors. It was testing the old ones. |
alvestrand
force-pushed
the
renegotiate-header-extensions
branch
from
4f2b661 to
1623cd9
Compare
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 20, 2025
This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Oct 20, 2025
This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532197}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 20, 2025
This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532197}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 20, 2025
This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532197}
maitrungduc1410
pushed a commit
to maitrungduc1410/webrtc
that referenced
this pull request
Oct 21, 2025
Spec change: w3c/webrtc-extensions#238 Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 Bug: webrtc:439514253 Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Guido Urdaneta <[email protected]> Cr-Commit-Position: refs/heads/main@{#45993}
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Oct 24, 2025
… spec changes, a=testonly Automatic update from web-platform-tests Modify headerExtensionControl test after spec changes This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532197} -- wpt-commits: 7314290de2f3fae9bc12c8c14a7b936d6b6b6000 wpt-pr: 55544
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Oct 25, 2025
… spec changes, a=testonly Automatic update from web-platform-tests Modify headerExtensionControl test after spec changes This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532197} -- wpt-commits: 7314290de2f3fae9bc12c8c14a7b936d6b6b6000 wpt-pr: 55544
mertcanaltin
pushed a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 26, 2025
This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532197}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 29, 2025
… spec changes, a=testonly Automatic update from web-platform-tests Modify headerExtensionControl test after spec changes This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <perkjchromium.org> Commit-Queue: Harald Alvestrand <htachromium.org> Cr-Commit-Position: refs/heads/main{#1532197} -- wpt-commits: 7314290de2f3fae9bc12c8c14a7b936d6b6b6000 wpt-pr: 55544 UltraBlame original commit: 0e1d4ce40c612c68d56a09b7d4ea5a93d5a29659
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 29, 2025
… spec changes, a=testonly Automatic update from web-platform-tests Modify headerExtensionControl test after spec changes This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <perkjchromium.org> Commit-Queue: Harald Alvestrand <htachromium.org> Cr-Commit-Position: refs/heads/main{#1532197} -- wpt-commits: 7314290de2f3fae9bc12c8c14a7b936d6b6b6000 wpt-pr: 55544 UltraBlame original commit: 0e1d4ce40c612c68d56a09b7d4ea5a93d5a29659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
Preview | Diff