Skip to content

Adds dark mode and simplify CSS #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds dark mode and simplify CSS #33

wants to merge 2 commits into from

Conversation

Tpt
Copy link

@Tpt Tpt commented Mar 5, 2025 •
edited by pr-preview bot
Loading

  • use http syntax highlight instead of req/resp nohighlight, it draws a box in both light and dark mode
  • use default pre style for sparql, migrate to the sparql style in the hope of a syntax highlighter
  • drop the style block that is unused

Preview | Diff

@Tpt
* use http syntax highlight instead of req/resp nohighlight, it draws…
23fb283 
… a box in both light and dark mode

* use default pre style for sparql, migrate to the sparql style in the hope of a syntax highlighter
* drop the style block that is unused
@Tpt Tpt requested review from afs, kasei and rubensworks March 5, 2025 13:40
@Tpt Tpt self-assigned this Mar 5, 2025
afs
afs reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@afs afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table styling in 2.1 and 2.2 isn't happening anymore.

@afs afs self-requested a review March 6, 2025 08:35
@Tpt Tpt added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Mar 20, 2025
@Tpt
Copy link
Author

Tpt commented Mar 20, 2025

I have added back table styling using class="data"

@Tpt Tpt mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domel domel domel approved these changes

@kasei kasei Awaiting requested review from kasei

@rubensworks rubensworks Awaiting requested review from rubensworks

@afs afs Awaiting requested review from afs

Assignees

@Tpt Tpt

Labels

spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tpt @afs @domel