Skip to content

fix($core): set NODE_ENV before creating app #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2019
Merged

fix($core): set NODE_ENV before creating app #1972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c932991
fix($core): Set production mode before creating VuePress app on build…
kefranabg Oct 23, 2019
2e79ab5
feat: Set NODE_ENV to 'development' when using dev command
kefranabg Oct 30, 2019
5b6506a
fix($core): merge #2028
meteorlxy Nov 27, 2019
3614eb5
fix: avoid overwriting NODE_ENV
meteorlxy Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/@vuepress/core/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,18 @@ function createApp (options) {
}

async function dev (options) {
if (process.env.NODE_ENV === undefined) {
process.env.NODE_ENV = 'development'
}
const app = createApp(options)
await app.process()
return app.dev()
}

async function build (options) {
if (process.env.NODE_ENV === undefined) {
process.env.NODE_ENV = 'production'
}
const app = createApp(options)
await app.process()
return app.build()
Expand Down
3 changes: 1 addition & 2 deletions packages/@vuepress/core/lib/node/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ module.exports = class App {
*/

constructor (options = {}) {
this.isProd = process.env.NODE_ENV === 'production'
this.options = options
this.sourceDir = this.options.sourceDir || path.join(__dirname, 'docs.fallback')
logger.debug('sourceDir', this.sourceDir)
Expand Down Expand Up @@ -459,7 +460,6 @@ module.exports = class App {
*/

async dev () {
this.isProd = false
this.devProcess = new DevProcess(this)
await this.devProcess.process()
const error = await new Promise(resolve => {
Expand Down Expand Up @@ -489,7 +489,6 @@ module.exports = class App {
*/

async build () {
this.isProd = true
this.buildProcess = new BuildProcess(this)
await this.buildProcess.process()
await this.buildProcess.render()
Expand Down
1 change: 0 additions & 1 deletion packages/@vuepress/core/lib/node/build/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const { normalizeHeadTag, applyUserWebpackConfig } = require('../util/index')
module.exports = class Build extends EventEmitter {
constructor (context) {
super()
process.env.NODE_ENV = 'production'
this.context = context
this.outDir = this.context.outDir
}
Expand Down