fix: render all slots inside a <template> vnode #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
reviewed
Sep 26, 2018
| return createVNodes(vm, slotValue, name) | ||
| } | ||
| const vnode = vm.$createElement(slotValue) | ||
| ;(vnode.data || (vnode.data = {})).slot = name |
Member
Author
There was a problem hiding this comment.
It sets vnode.data.slot to equal the slot name. It's shorthand for:
if(!vnode.data) {
vnode.data = {}
}
vnode.data.slot = name
Member
There was a problem hiding this comment.
I see! haven't seen this syntax before. I take it the preceeding ; is required.
Member
Author
There was a problem hiding this comment.
Yes, that's is one of the drawbacks of not including semi-colons, there are a few other cases where no semi-colons will cause errors.
Member
There was a problem hiding this comment.
Fair enough.
Code looks good outside that, good job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #967