Skip to content

fix: typing error with props and attributes #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2018
Merged

fix: typing error with props and attributes #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b47462
test: add attributes() and props() to type test
vwxyutarooo Feb 15, 2018
a949831
fix: type props and attributes in BaseWrapper #432
vwxyutarooo Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ interface BaseWrapper {
exists (): boolean
visible (): boolean

attributes(): { [name: string]: string } | void
attributes(): { [name: string]: string }
classes(): Array<string> | void
props(): { [name: string]: any } | void
props(): { [name: string]: any }

hasAttribute (attribute: string, value: string): boolean
hasClass (className: string): boolean
Expand Down
2 changes: 2 additions & 0 deletions types/test/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ bool = wrapper.contains(ClassComponent)
bool = wrapper.exists()

bool = wrapper.hasAttribute('foo', 'bar')
bool = wrapper.attributes().foo === 'bar'
bool = wrapper.hasClass('foo-class')
bool = wrapper.hasProp('checked', true)
bool = wrapper.props().checked
bool = wrapper.hasStyle('color', 'red')

bool = wrapper.is(normalOptions)
Expand Down