Skip to content

Conversation

@zhiyuanzmj
Copy link
Member

@zhiyuanzmj zhiyuanzmj commented Aug 30, 2025

  1. defineVaporComponent types.
  • Functional defineVaporComponent
import { computed, type ComputedRef, type Block } from 'vue'

const Comp = defineVaporComponent(
    <T extends number>(
      props: { foo: T },
      {
        expose,
        slots,
      }: {
        slots: { default?: (props: { foo: T }) => Block }
        expose: (exposed: { double: ComputedRef<T> }) => void
      },
    ) => {
      const double = computed(() => (props.foo * 2) as T)
      expose({ double })
      return slots.default!({ foo: props.foo })
    },
)

const comp = new Comp<1>({ foo: 1 })
comp.props.foo === ({} as 1)
comp.exposeProxy?.double === ({} as 1)
comp.slots === ({} as { default?: (props: { foo: 1 }) => Block })
  • Optional defineVaporComponent
const Comp = defineVaporComponent({
  props: {
    foo: {
      type: Number,
      required: true,
    }
  },
  slots: {} as { default?: (props: { foo: number }) => Block }
  setup(props){
    const double = computed(() => props.foo * 2)
    return {
      double
    }
  },
  render(ctx, props, emit, attrs, slots){
    return slots.default?.({ foo: props.foo })
  }
})

const comp = new Comp({ foo: 1 })
comp.props.foo === {} as number
comp.exposeProxy?.double === {} as number
comp.slots === ({} as { default?: (props: { foo: number }) => Block })
  1. Remove JSX.ElementAttributesProperty and JSX.ElementClass to enable Vapor and VDom co-usage.
// jsx.d.ts
declare global {
  namespace JSX {
    export type Element = VNode | Block
  }
}

Using the constructor's first parameter as JSX props instead.

interface Constructor<P = any> {
  new (props?: P): { $props: P }
  //   ^^^^^^^^^
}

@coderabbitai
Copy link

coderabbitai bot commented Aug 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Aug 30, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.8 kB 30 kB 26.5 kB
runtime-dom.global.prod.js 106 kB 39.8 kB 35.8 kB
vue.global.prod.js 164 kB 60 kB 53.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.8 kB 18.7 kB 17.1 kB
createApp 56.6 kB 21.8 kB 19.9 kB
createApp + vaporInteropPlugin 90.1 kB (+128 B) 33.7 kB (+44 B) 30.5 kB (+50 B)
createVaporApp 34 kB (+128 B) 13 kB (+45 B) 11.8 kB (+39 B)
createSSRApp 60.9 kB 23.6 kB 21.5 kB
defineCustomElement 62 kB 23.4 kB 21.4 kB
overall 71.6 kB 27.2 kB 24.7 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 30, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13831

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13831

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13831

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13831

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13831

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13831

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13831

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13831

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13831

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13831

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13831

vue

npm i https://pkg.pr.new/vue@13831

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13831

commit: c57e25e

@netlify
Copy link

netlify bot commented Aug 30, 2025

Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit f7d7d7a
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68d02335be19150008d67045

@zhiyuanzmj zhiyuanzmj added the scope: vapor related to vapor mode label Aug 31, 2025
@zhiyuanzmj zhiyuanzmj changed the title feat(vapor): implement defineVaporComponent types feat(runtime-vapor): implement defineVaporComponent types Aug 31, 2025
@edison1105
Copy link
Member

/ecosystem-ci run

@vuejs vuejs deleted a comment from zhiyuanzmj Nov 5, 2025
@vue-bot
Copy link
Contributor

vue-bot commented Nov 5, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
quasar success success
radix-vue success success
pinia success success
nuxt failure success
test-utils failure success
router success success
language-tools success success
vant success success
vite-plugin-vue success success
primevue success success
vue-i18n success failure
vitepress failure success
vue-macros failure success
vuetify failure success
vueuse failure success
vue-simple-compiler success success

@edison1105 edison1105 moved this to Vapor in Next Minor Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode version: minor

Projects

Status: Vapor

Development

Successfully merging this pull request may close these issues.

3 participants