Updates for Python 3.10 and some housecleaning #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does NOT mean Python 3.7 is no longer supported. Just trying to keep the number of builds a little reasonable.
sspickle
reviewed
Jan 6, 2022
.github/workflows/upload_pypi.yml
Outdated
| matrix: | ||
| python-version: [3.7, 3.8, 3.9] | ||
| platform: [macos-latest, windows-latest] # No wheels on linux yet | ||
| python-version: [3.7, 3.8, 3.9, 3.10] |
Contributor
There was a problem hiding this comment.
Should this 3.10 be '3.10' like the others? I see it's in a '.yml' file, so maybe it's smart enough, but if these get parsed as a python list, it might end up as 3.1 rather than '3.10'.
Contributor
Author
There was a problem hiding this comment.
Weird -- I had already changed that...not sure why the quotes aren't showing up for you.
Contributor
There was a problem hiding this comment.
Do you see the quotes there now? Line 14 of .github/workflows/upload_pypi.yml ?
Contributor
There was a problem hiding this comment.
Indeed! I see them in your branch, but not in the PR for some reason. Weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
3.7.setup.pythat addsautobahnas a dependency for some old Python versions. We now requireautobahnalways.__init__.pythat is trying to check for Python 2.7 or 3.4, neither of which we support.