Skip to content

Incorrect Minor Version Check for Python 3.10. Fails >= 3.5 Check. #173

@Axe319

Description

@Axe319

__require_notebook = (not __ispython3) or (__p[2] < '5') # Python 2.7 or 3.4 require Jupyter notebook

The current implementation utilizes platform.python_version() and does a < '5' check against one character of the string.
A more stable way to check would be to use sys.version_info.major and sys.version_info.minor respectively.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions