Fix flaky testTaggedUnionsWithInterfaces by sorting elements in Emitter (deterministic solution) #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Is this test still flaky on the latest version of the project? How do you know?
-This test (testTaggedUnionsWithInterfaces) is no longer flaky, because it was changed to be deterministic using a sorting addition to emitter.
(2) Are there any existing opened pull requests for flaky tests in this repository? Are any of these opened pull requests for this flaky test?
I don't know if I solved the flakiness of more than one test, but this test specifically does have a pull request
(3) Are there any closed/rejected PRs related to flaky tests in this repository? What flaky tests are these closed/rejected PRs for and why were they rejected?
No.