-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[ci] breaks down V1 Test into 3 groups of approx 30 minutes runtime #23757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] breaks down V1 Test into 3 groups of approx 30 minutes runtime #23757
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to reduce CI latency by splitting the 'V1 Tests' job into three parallel jobs. The implementation correctly separates the longest-running test suites, v1/e2e
and v1/entrypoints
, into their own jobs. However, there are two key areas for improvement. First, the new 'V1 Test (others)' job is missing a necessary source file dependency, which could cause it to not run when it should. Second, the distribution of tests among the new jobs is unbalanced, leaving one job with a runtime of nearly an hour. A more balanced distribution could further reduce the overall CI wall-clock time.
Signed-off-by: Jean Schmidt <[email protected]>
4a7da1c
to
e06963c
Compare
Signed-off-by: Jean Schmidt <[email protected]>
Signed-off-by: Jean Schmidt <[email protected]>
f539987
to
7e7273c
Compare
Signed-off-by: Jean Schmidt <[email protected]>
Signed-off-by: Jean Schmidt <[email protected]>
Signed-off-by: Jean Schmidt <[email protected]>
…llm-project#23757) Signed-off-by: Jean Schmidt <[email protected]>
…llm-project#23757) Signed-off-by: Jean Schmidt <[email protected]>
…llm-project#23757) Signed-off-by: Jean Schmidt <[email protected]>
This PR is part of the CI sprint initiative, with the goal of reduce CI latency for tests.
This is following the first step from #23668
It breaks down 'V1 Tests' in 3 groups, this is based on the analysis of the wallclock for test runs:
as a important note, there are 3 outliers:
v1/e2e - 00:20
v1/entrypoints - 00:36
v1/engine - 00:13
it seems the most efficient approach would be breaking into the following groups:
v1/e2e - 00:20
v1/entrypoints - 00:36