[Model] Merge SupportsMultiModalWithRawInput with SupportsMultiModal
#23749
+30
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
added
the
ready
DarkLight1337
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac,
alexm-redhat,
simon-mo,
youkaichao,
mgoin,
tlrmchlsmth,
houseroad,
hmellor,
yewentao256 and
ProExpertProg
as code owners
DarkLight1337
changed the title
SupportsMultiModalWithRawInput with SupportsMultiModal
DarkLight1337
added
multi-modality
Isotr0py
approved these changes
Aug 27, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the multi-modal model interface by merging the SupportsMultiModalWithRawInput protocol into SupportsMultiModal. This simplification is achieved by introducing a new boolean flag, supports_multimodal_raw_input_only, which is a cleaner design. Downstream attributes and methods have been renamed for better clarity and consistency, such as is_multimodal_raw_input_only_model. The changes are applied consistently across all affected files, improving code maintainability. The refactoring is well-executed and I have no concerns.
|
Prithvi tests pass locally so this should be fine to merge |
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
…al` (vllm-project#23749) Signed-off-by: DarkLight1337 <[email protected]>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
…al` (vllm-project#23749) Signed-off-by: DarkLight1337 <[email protected]>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
…al` (vllm-project#23749) Signed-off-by: DarkLight1337 <[email protected]>
dumb0002
pushed a commit
to dumb0002/vllm
that referenced
this pull request
Aug 28, 2025
…al` (vllm-project#23749) Signed-off-by: DarkLight1337 <[email protected]>
2015aroras
pushed a commit
to 2015aroras/vllm
that referenced
this pull request
Aug 29, 2025
…al` (vllm-project#23749) Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Simplify the code since
SupportsMultiModalWithRawInputjust adds a single flag. Also rename downstream attributes to be more consistent with that of transcription-only models (e.g.supports_transcription_only).cc @mgazz @christian-pinto
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.