-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Adapting Qwen3-32B to Eagle3 mode to resolve head dimension mismatch issues #23740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coder-fny
wants to merge
1
commit into
vllm-project:main
Choose a base branch
from
coder-fny:qwen3_dense_eagle3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the spec of the first layer (
layer_specs[0]
) to represent the entire group can be problematic when layers have differenthead_size
values, as indicated by the PR's purpose. This leads to an incorrectKVCacheGroupSpec
for the group.For instance,
get_max_concurrency_for_kv_cache_config
usesgroup.kv_cache_spec.page_size_bytes
for its calculation. If the first layer has a smallerhead_size
than other layers in the group, itspage_size_bytes
will be smaller than the maximum page size used for allocation in_get_kv_cache_config_allFullAttentionSpec_type
. This will causemax_concurrency
to be overestimated, which could lead to out-of-memory errors at runtime.To ensure correctness, the
merged_layer_spec
should represent the most demanding configuration within the group, which corresponds to the layer with the largestpage_size_bytes
.