Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Aug 18, 2025

Purpose

It seems the latest openai python package release broke our CI, so let us pin below for now

https://app.readthedocs.org/projects/vllm/builds/29239011/

File "/home/docs/checkouts/readthedocs.org/user_builds/vllm/checkouts/22023/vllm/reasoning/deepseek_r1_reasoning_parser.py", line 9, in <module>
--
  | from vllm.entrypoints.openai.protocol import (ChatCompletionRequest,
  | File "/home/docs/checkouts/readthedocs.org/user_builds/vllm/checkouts/22023/vllm/entrypoints/openai/protocol.py", line 20, in <module>
  | from openai.types.responses import (ResponseFunctionToolCall,
  | ImportError: cannot import name 'ResponseTextConfig' from 'openai.types.responses' (/home/docs/checkouts/readthedocs.org/user_builds/vllm/envs/22023/lib/python3.12/site-packages/openai/types/responses/__init__.py). Did you mean: 'ResponseFormatTextConfig'?

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: mgoin <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins the openai package to versions below 1.100.0 to resolve a CI failure. This is a standard and effective approach for handling breaking changes in dependencies, ensuring the stability of the continuous integration pipeline. The change is straightforward and appropriate as an immediate fix. No issues of high or critical severity were found in this change.

@mgoin mgoin added the ci-failure Issue about an unexpected test failure in CI label Aug 18, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Docs build is still failing

Signed-off-by: mgoin <[email protected]>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 18, 2025
@mgoin mgoin enabled auto-merge (squash) August 18, 2025 18:35
@simon-mo simon-mo disabled auto-merge August 18, 2025 19:13
@simon-mo simon-mo merged commit bf75632 into vllm-project:main Aug 18, 2025
56 of 81 checks passed
h-brenoskuk pushed a commit to h-brenoskuk/vllm that referenced this pull request Aug 18, 2025
h-brenoskuk added a commit to h-brenoskuk/vllm that referenced this pull request Aug 18, 2025
h-brenoskuk added a commit to h-brenoskuk/vllm that referenced this pull request Aug 18, 2025
simon-mo pushed a commit that referenced this pull request Aug 18, 2025
princepride pushed a commit to princepride/vllm that referenced this pull request Aug 20, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
cyang49 pushed a commit to cyang49/vllm that referenced this pull request Aug 20, 2025
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ci-failure Issue about an unexpected test failure in CI ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants