-
-
Couldn't load subscription status.
- Fork 10.8k
Use Blackwell FlashInfer MXFP4 MoE by default if available #23008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Blackwell FlashInfer MXFP4 MoE by default if available #23008
Conversation
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables the Blackwell FlashInfer MXFP4 MoE backend by default when available. The changes introduce helper functions to centralize the logic for determining which FlashInfer backend to use and refactor the existing code to call these helpers. A helpful warning is also added for users on Blackwell hardware when FlashInfer is not installed. The overall changes are well-structured. I've identified one high-severity issue regarding the prioritization of FlashInfer backends, which could lead to using a less performant kernel even when a faster one is enabled. A code suggestion is provided to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
Signed-off-by: mgoin <[email protected]>
|
sm120 / rtx 50xx gonna finally works too ? |
…ect#23008) Signed-off-by: mgoin <[email protected]>
…ect#23008) Signed-off-by: mgoin <[email protected]>
…ect#23008) Signed-off-by: mgoin <[email protected]>
…ect#23008) Signed-off-by: mgoin <[email protected]>
…ect#23008) Signed-off-by: mgoin <[email protected]>
…ect#23008) Signed-off-by: mgoin <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…ect#23008) Signed-off-by: mgoin <[email protected]>
…ect#23008) Signed-off-by: mgoin <[email protected]>
…ect#23008) Signed-off-by: mgoin <[email protected]>
| if current_platform.is_cuda() and \ | ||
| not current_platform.has_device_capability(100): | ||
| if not current_platform.is_device_capability(90): | ||
| not current_platform.is_device_capability(100): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are sm120 such as RTX 6000 Pro Blackwell , shouldn't we include those as well ?
Purpose
Essentially we should act like
VLLM_USE_FLASHINFER_MOE_MXFP4_BF16=1if on SM100 and flashinfer is installedTest Plan
Test Result
Main branch:
This PR:
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.