Skip to content

Conversation

LouieYang
Copy link
Contributor

@LouieYang LouieYang commented Feb 28, 2025

Similar issue as #13468 where the attention bias in vLLM's xformers backend is currently initialized on the default device, rather than the device of the Q/K/V tensors.

The #13468 workaround doesn't quite solve the problem for QwenVL series when vLLM is used in conjunction with libraries like trl for GRPO training.

The cuda device mismatched issue still exists for xformer backend.

[rank0]: ValueError: Attention bias and Query/Key/Value should be on the same device

This PR solve cuda device mismatch problem for QwenVL Series

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py
Copy link
Member

Can you please address the pre-commit linting errors?

@Isotr0py Isotr0py enabled auto-merge (squash) February 28, 2025 13:43
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 28, 2025
@vllm-bot vllm-bot merged commit 9b61dd4 into vllm-project:main Feb 28, 2025
46 of 50 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants