Skip to content

Conversation

yannicks1
Copy link
Collaborator

[cb][test] add tests for volumetric constraint with prefill optimization

Adds tests for the volumetric constraint (PR #363) VLLM_DT_MAX_BATCH_TKV_LIMIT combined with the prefill optimization (PR #340) (currently behind a feature flag VLLM_SPYRE_ENABLE_PREFILL_OPTIMIZATION).

Changes:

  • test_requests_use_full_batch_tkv_limit_prefill_opt: just big enough volume -> can prefill sequence with optimization
  • test_requests_exceed_batch_tkv_limit_prefill_opt: exceeding volume -> cannot prefill sequence with optimization, have to decode current sequence first...

@yannicks1 yannicks1 self-assigned this Aug 28, 2025
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Signed-off-by: Yannick Schnider <[email protected]>
@yannicks1
Copy link
Collaborator Author

bot:test

@yannicks1 yannicks1 marked this pull request as ready for review August 28, 2025 14:35
Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lpgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants