-
Notifications
You must be signed in to change notification settings - Fork 532
Add FAQ for docker pull error on Kylin OS #3870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added instructions for resolving 'invalid tar header' error on Kylin OS during docker pull, including steps for offline loading of docker images. Signed-off-by: Liwx <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a valuable FAQ entry for resolving a docker pull error on Kylin OS. The instructions are clear and provide a solid workaround. My review focuses on improving the maintainability and clarity of the provided shell commands by removing hardcoded values and making the instructions more robust for future versions. I've suggested using a variable for the Docker image tag and updating the subsequent steps to reflect this change, which will prevent the documentation from becoming outdated.
|
Can you fix the lint error? Otherwise LGTM |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Liwx <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Liwx <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Liwx <[email protected]>
Thanks for the review! I've pushed the fix for the lint error. It was indeed caused by an extra trailing space. The CI should pass now. |
Added instructions for resolving 'invalid tar header' error on Kylin OS (麒麟操作系统) with an ARM64 architecture on Atlas300I hardware during docker pull, including steps for offline loading of docker images.
What this PR does / why we need it?
The primary motivation for this PR is to address a critical
docker pullfailure that occurs on specific, yet important, enterprise environments. Specifically, when operating on Kylin OS (麒麟操作系统) with an ARM64 architecture on Atlas300I hardware, users frequently encounter anarchive/tar: invalid tar headererror, which completely blocks the setup process. This issue has been consistently reproduced, with multiple retries failing with the same error, confirming that it is a persistent environmental problem rather than a transient network issue.This guide provides a robust, step-by-step workaround using an offline-loading method (
docker saveon a host machine anddocker loadon the target machine). This solution is crucial for enabling users on this platform to use vLLM.This contribution does not directly fix an existing issue number, but it proactively solves a significant environmental and usability problem for a growing user base.
Does this PR introduce any user-facing change?
No.It does not alter any code, APIs, interfaces, or existing behavior of the vLLM project.
How was this patch tested?
The instructions and troubleshooting steps in this guide were validated through a real-world, end-to-end test case on the my hardware and OS.
The testing process was as follows:
docker pullthevllm-ascend:v0.10.0rc1-310pimage on a target machine running Kylin OS (ARM64). Theinvalid tar headerfailure was successfully and consistently reproduced, confirming the existence of the problem.--platform linux/arm64flag..tararchive usingdocker save..tararchive was transferred to the target Kylin OS machine.docker load -i ....curlto the API server) and offline inference (via the Python script) were executed successfully, confirming that the entire workflow described in the document is accurate and effective.Since this is a documentation-only change based on a validated workflow, no new unit or integration tests were added to the codebase.