Skip to content

Tell compiler about intentional fallthrough. #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2023
Merged

Tell compiler about intentional fallthrough. #2189

merged 2 commits into from
Apr 28, 2023

Conversation

@hzeller
Copy link
Contributor

@hzeller hzeller commented Nov 3, 2022

Tiny cleanup.

@hzeller
Copy link
Contributor Author

hzeller commented Nov 3, 2022

This is a c++17 feature, though CMakeLists talks about c++14. Maybe it is time to up to C++17 ?

@hzeller
Copy link
Contributor Author

hzeller commented Nov 3, 2022

Added c++17 requirement in #2190 - once that is submitted, this one is submittable.

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Nov 3, 2022
@hzeller hzeller requested a review from vaughnbetz April 26, 2023 17:40
@vaughnbetz vaughnbetz merged commit 2840290 into verilog-to-routing:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaughnbetz vaughnbetz Awaiting requested review from vaughnbetz

Assignees

No one assigned

Labels

VPR VPR FPGA Placement & Routing Tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hzeller @vaughnbetz