Skip to content

[backport v14]: fix(next/image): fix image-optimizer.ts headers (#82114) #82178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

[backport v14]: fix(next/image): fix image-optimizer.ts headers (#82114) #82178

merged 1 commit into from
Jul 29, 2025

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Jul 29, 2025

@styfle @ztanner
fix(next/image): fix image-optimizer.ts headers (#82114)
d6bc463 
The headers were forwarded to the serverless function for "internal"
images but not "external" images.

This changes the behavior to be the same for both such that neither
receive headers.
@ztanner ztanner requested a review from ijjk July 29, 2025 21:00
@ijjk
Copy link
Member

ijjk commented Jul 29, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
buildDuration 15.6s 12.9s N/A
buildDurationCached 7.9s 6.1s N/A
nodeModulesSize 201 MB 201 MB N/A
nextStartRea..uration (ms) 343ms 361ms N/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
1a9f679d-HASH.js gzip 53.7 kB 53.7 kB ✓
5428.HASH.js gzip 181 B 180 B N/A
6067-HASH.js gzip 5.14 kB 5.14 kB ✓
6428-HASH.js gzip 31.6 kB 31.6 kB N/A
framework-HASH.js gzip 44.9 kB 44.9 kB ✓
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 104 kB 104 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
_app-HASH.js gzip 196 B 196 B ✓
_error-HASH.js gzip 184 B 185 B N/A
amp-HASH.js gzip 502 B 504 B N/A
css-HASH.js gzip 321 B 324 B N/A
dynamic-HASH.js gzip 1.82 kB 1.82 kB N/A
edge-ssr-HASH.js gzip 258 B 257 B N/A
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 371 B 372 B N/A
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 259 B 257 B N/A
link-HASH.js gzip 2.67 kB 2.68 kB N/A
routerDirect..HASH.js gzip 316 B 314 B N/A
script-HASH.js gzip 385 B 386 B N/A
withRouter-HASH.js gzip 311 B 310 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 654 B 654 B ✓
Client Build Manifests
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
_buildManifest.js gzip 484 B 481 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
index.html gzip 528 B 528 B ✓
link.html gzip 542 B 539 B N/A
withRouter.html gzip 525 B 524 B N/A
Overall change 528 B 528 B ✓
Edge SSR bundle Size
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
edge-ssr.js gzip 95.7 kB 95.7 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
middleware-b..fest.js gzip 659 B 657 B N/A
middleware-r..fest.js gzip 156 B 154 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 839 B 839 B ✓
Next Runtimes
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
app-page-exp...dev.js gzip 172 kB 172 kB ✓
app-page-exp..prod.js gzip 98.4 kB 98.4 kB ✓
app-page-tur..prod.js gzip 100 kB 100 kB ✓
app-page-tur..prod.js gzip 94.4 kB 94.4 kB ✓
app-page.run...dev.js gzip 146 kB 146 kB ✓
app-page.run..prod.js gzip 92.9 kB 92.9 kB ✓
app-route-ex...dev.js gzip 22.6 kB 22.6 kB ✓
app-route-ex..prod.js gzip 16 kB 16 kB ✓
app-route-tu..prod.js gzip 16 kB 16 kB ✓
app-route-tu..prod.js gzip 15.7 kB 15.7 kB ✓
app-route.ru...dev.js gzip 22.2 kB 22.2 kB ✓
app-route.ru..prod.js gzip 15.7 kB 15.7 kB ✓
pages-api-tu..prod.js gzip 9.58 kB 9.58 kB ✓
pages-api.ru...dev.js gzip 9.85 kB 9.85 kB ✓
pages-api.ru..prod.js gzip 9.57 kB 9.57 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.2 kB 23.2 kB ✓
pages.runtim..prod.js gzip 22.5 kB 22.5 kB ✓
server.runti..prod.js gzip 51.8 kB 51.8 kB ✓
Overall change 961 kB 961 kB ✓
build cache Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js ztanner/backport-82114 Change
0.pack gzip 1.65 MB 1.65 MB ⚠️ +764 B
index.pack gzip 115 kB 115 kB ⚠️ +155 B
Overall change 1.76 MB 1.76 MB ⚠️ +919 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: d6bc463

@ijjk
Copy link
Member

ijjk commented Jul 29, 2025 •
edited
Loading

Failing test suites

Commit: d6bc463

pnpm test-start test/e2e/prerender-native-module.test.ts

  • prerender native module > should render index correctly
  • prerender native module > should render /blog/first correctly
  • prerender native module > should render /blog/second correctly
  • prerender native module > should output traces
Expand output

● prerender native module › should render index correctly

next build failed with code/signal 1

  90 |           if (code || signal)
  91 |             reject(
> 92 |               new Error(`next build failed with code/signal ${code || signal}`)
     |               ^
  93 |             )
  94 |           else resolve()
  95 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:92:15)

● prerender native module › should render /blog/first correctly

next build failed with code/signal 1

  90 |           if (code || signal)
  91 |             reject(
> 92 |               new Error(`next build failed with code/signal ${code || signal}`)
     |               ^
  93 |             )
  94 |           else resolve()
  95 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:92:15)

● prerender native module › should render /blog/second correctly

next build failed with code/signal 1

  90 |           if (code || signal)
  91 |             reject(
> 92 |               new Error(`next build failed with code/signal ${code || signal}`)
     |               ^
  93 |             )
  94 |           else resolve()
  95 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:92:15)

● prerender native module › should output traces

next build failed with code/signal 1

  90 |           if (code || signal)
  91 |             reject(
> 92 |               new Error(`next build failed with code/signal ${code || signal}`)
     |               ^
  93 |             )
  94 |           else resolve()
  95 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:92:15)

● Test suite failed to run

TypeError: Cannot read properties of undefined (reading 'destroy')

  23 |     })
  24 |   })
> 25 |   afterAll(() => next.destroy())
     |                       ^
  26 |
  27 |   it('should render index correctly', async () => {
  28 |     const browser = await webdriver(next.url, '/')

  at Object.destroy (e2e/prerender-native-module.test.ts:25:23)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/turbopack-reports/turbopack-reports.test.ts

  • turbopack-reports > should render page importing sqlite3
Expand output

● turbopack-reports › should render page importing sqlite3

expect(received).toBe(expected) // Object.is equality

Expected: "Hello World"
Received: ""

  12 |     it('should render page importing sqlite3', async () => {
  13 |       const $ = await next.render$('/sqlite-import-5913')
> 14 |       expect($('#message').text()).toBe('Hello World')
     |                                    ^
  15 |     })
  16 |   }
  17 | )

  at Object.toBe (e2e/app-dir/turbopack-reports/turbopack-reports.test.ts:14:36)

Read more about building and testing Next.js in contributing.md.

@austinderek austinderek mentioned this pull request Jul 29, 2025
Closed
@ztanner ztanner merged commit bcc7c65 into 14-2-1 Jul 29, 2025
87 of 100 checks passed
@ztanner ztanner deleted the ztanner/backport-82114 branch July 29, 2025 22:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked tests type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ztanner @ijjk @styfle