Skip to content

Conversation

@MrFreezeex
Copy link

Add loadBalancerSourceRanges field on service to be able to whitelist traffic client traffic by IP

@pront pront requested a review from Copilot July 7, 2025 20:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Add support for specifying loadBalancerSourceRanges on both the main service and the HAProxy service so users can whitelist client IP ranges.

  • Define new loadBalancerSourceRanges fields (default []) in values.yaml
  • Render these fields in the service templates when non-empty
  • Update documentation and bump chart version to 0.45.0

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
charts/vector/values.yaml Add default loadBalancerSourceRanges fields with explanatory comments
charts/vector/templates/service.yaml Render loadBalancerSourceRanges under spec when provided
charts/vector/templates/haproxy/service.yaml Render loadBalancerSourceRanges for HAProxy service when provided
charts/vector/README.md Document new values and bump the version badge
charts/vector/Chart.yaml Bump chart version from 0.44.0 to 0.45.0
Comments suppressed due to low confidence (3)

charts/vector/templates/service.yaml:23

  • [nitpick] Indent this if block to match the surrounding two-space indentation for consistency and to avoid template parsing issues.
{{- if .Values.service.loadBalancerSourceRanges }}

charts/vector/templates/haproxy/service.yaml:19

  • [nitpick] Align the indentation of this if block with the other service template blocks to maintain consistent formatting.
{{- if .Values.haproxy.service.loadBalancerSourceRanges }}

charts/vector/templates/service.yaml:23

  • Consider adding Helm chart tests or unit tests to verify that loadBalancerSourceRanges renders correctly when populated and omitted when empty.
{{- if .Values.service.loadBalancerSourceRanges }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant