Skip to content

Conversation

@camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Aug 18, 2025

Use locale: instead of local: for isPhoneNumber test.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Use `locale:` instead of `local:` for isPhoneNumber test.
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (abcc8ec) to head (9049b6f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2581   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2535      2535           
  Branches       641       641           
=========================================
  Hits          2535      2535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik
Copy link
Member

WikiRik commented Aug 18, 2025

Good catch! However this should have been an error in the test runs before, I'll look into why we haven't implemented such a check

@camillobruni
Copy link
Contributor Author

From what I understood this just goes into the "any" fallback, maybe the invalid phone numbers are accidentally "globally" invalid?

@WikiRik WikiRik requested a review from rubiin September 3, 2025 09:18
@WikiRik
Copy link
Member

WikiRik commented Sep 3, 2025

From what I understood this just goes into the "any" fallback, maybe the invalid phone numbers are accidentally "globally" invalid?

Yes, something like that seems to be happening indeed. I've added a check locally for other unexpected attributes in that fixtures array but those seem good. When we do a bigger update to the test helper functions I'll add that (or when we move to TypeScript). For now this change is fine to merge

@rubiin rubiin merged commit 6f436be into validatorjs:master Sep 3, 2025
13 checks passed
@camillobruni camillobruni deleted the patch-1 branch September 3, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants