Skip to content

Conversation

larsuzh
Copy link
Contributor

@larsuzh larsuzh commented May 7, 2024

if a user is inside his own profile, the delete button is displayed
image
when pressed, an alert is displayed
image

@larsuzh larsuzh linked an issue May 7, 2024 that may be closed by this pull request
@larsuzh larsuzh requested review from chrsBa and flyingbeat May 7, 2024 11:38
Copy link
Contributor

@flyingbeat flyingbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to fix light mode are not necessary (see comment), and position of trash icon can be improved otherwise looks great!

larsuzh added 3 commits May 8, 2024 10:43
…-of-riddles

# Conflicts:
#	src/app/shared/location-riddle-post/location-riddle-post.component.html
#	src/app/shared/location-riddle-post/location-riddle-post.component.ts
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@larsuzh larsuzh dismissed flyingbeat’s stale review May 8, 2024 08:58

implemented

@larsuzh
Copy link
Contributor Author

larsuzh commented May 8, 2024

image

@larsuzh larsuzh merged commit 35211d0 into develop May 8, 2024
@larsuzh larsuzh deleted the 58-enable-deletion-of-riddles branch May 8, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable deletion of riddles

2 participants