This repository was archived by the owner on Oct 1, 2023. It is now read-only.
Added overlay #109
Open
Added overlay #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please ammend your commit with conflicts resolves? |
|
Thanks for replying on it.
This pull request is not on latest branch. This pull request is having an
overlay implementation for angularjs code on branch 0.8.1.
As few people are still working on angularjs 1.x. So it will be helpful for
them.
Please update this pull request on branch 0.8.1 only.
Thanks
Vikas
…On 1 Aug. 2017 21:35, "Islam Attrash" ***@***.***> wrote:
Can you please ammend your commit with conflicts resolves?
I think you didn't rebased the codebase a while ago
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ9m4sv65H3BjobVzIDCW6Dtv7Uvu0IKks5sTw1pgaJpZM4OpYVu>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Uri
I have added overlay on older angularjs spinner. Please merge it on angularjs-spinner-overlay branch. Few folks are still working on angularjs version, so it will be helpful for them.
Please let me know your thoughts, if it doesn't seem fit to you.
Thanks
Vikas Vaidya