Skip to content

Conversation

Lord255
Copy link
Contributor

@Lord255 Lord255 commented Jan 11, 2023

according to the readme the default BASE_URL should be /unrealircd-webpanel/

according to the readme the default BASE_URL should be /unrealircd-webpanel/
@ValwareIRC
Copy link
Member

The default should probably be assumed to be the web root directory i.e. example.com/ instead of example.com/unrealircd-webpanel. So, /.

Indeed it would be called /unrealircd-webpanel/ if you cloned the repository as-is inside your web root directory instead of doing something like rm -rf /var/www/html && git clone https://github.com/unrealircd/unrealircd-webpanel /var/www/html to completely delete and replace your web root with the panel, making it accessible at example.com/

@Lord255
Copy link
Contributor Author

Lord255 commented Jan 11, 2023

mhm. well. idk who, but i never overwrite the webroot with such things.
usually ppl use https://example.com as their own wbsite, and create folders and separate "project" like this too.

the readme suggests to go to /var/www/html, clone the repo, which default creates the unrealircd-webpanel folder, which is simple and clean, so this is why i suggested that hte base_url should be like that.

so.. based on the readme (which i agree with!; i wouldnt ever put things to https:/example.com) i did the update, cuz i think it should be the default. :)
(if you modify the readme, i could totally agree with skipping this, but tbh i like it this way :))

@ValwareIRC ValwareIRC merged commit 046d472 into unrealircd:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants