feat: WIP WIP WIP gateway #3732

Flo4604 · 2025-08-05T14:44:34Z

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Test A
Test B

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

vercel · 2025-08-05T14:44:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
dashboard	Ignored	Preview		Aug 27, 2025 8:56pm
engineering	Ignored	Preview		Aug 27, 2025 8:56pm

coderabbitai · 2025-08-05T14:44:41Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat_gateway

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

changeset-bot · 2025-08-05T15:59:16Z

⚠️ No Changeset found

Latest commit: 1dfd69e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…eway

go/apps/ctrl/services/acme/certificate_verification.go

chronark · 2025-08-26T18:03:49Z

go/apps/ctrl/services/acme/certificate_workflow.go

+
+// NewCertificateChallenge creates a new certificate challenges workflow instance
+// and ensures that we have a valid ACME User
+func NewCertificateChallenge(config CertificateChallengeConfig) *CertificateChallenge {


since you have been writing a workflow from scratch, how did it feel?
what can we improve?

I think we should add an indompoency id to a workflow run so if I spawn multiple tasks with the same one only the first one gets ran for a cooldown of XX duration

chronark · 2025-08-26T18:09:16Z

go/apps/ctrl/services/acme/user.go

+}
+
+func (u *AcmeUser) GetEmail() string {
+	return fmt.Sprintf("%s@%s", u.WorkspaceID, "unkey.fun")


can we leave that email as is?

I will make it configurable

chronark · 2025-08-26T18:09:43Z

go/apps/ctrl/services/acme/user.go

+	}
+
+	if !foundUser.RegistrationUri.Valid {
+		// todo: finish registration


adding a comment so we don't forget this todo

chronark · 2025-08-26T18:29:59Z

go/apps/gw/router/register.go

+	proxyService, err := proxy.New(proxy.Config{
+		Logger:              svc.Logger,
+		MaxIdleConns:        transport.MaxIdleConns,
+		IdleConnTimeout:     "90s",


why don't we use time.Duration?

Flo4604 · 2025-08-26T20:36:00Z

go/pkg/kv/store.go

+import (
+	"context"
+	"time"
+)
+
+// Store defines the interface for a key-value store with TTL support
+type Store interface {
+	Get(ctx context.Context, key string) ([]byte, bool, error)
+	Set(ctx context.Context, key string, workspaceID string, value []byte, ttl *time.Duration) error
+	Delete(ctx context.Context, key string) error
+	ListByWorkspace(ctx context.Context, workspaceID string, cursor int64, limit int) ([]KvEntry, error)
+}


cc @chronark do we even need this anymore?

Flo4604 · 2025-08-26T20:41:11Z

go/proto/ctrl/v1/acme.proto

+
+import "google/protobuf/timestamp.proto";
+
+message HandleCertificateVerificationRequest {


I'm open for a differen name

Flo4604 · 2025-08-27T12:18:00Z

@coderabbitai review

coderabbitai · 2025-08-27T12:18:07Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Flo4604 · 2025-08-27T15:16:42Z

@coderabbitai review

coderabbitai · 2025-08-27T15:16:48Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

chronark and others added 10 commits August 4, 2025 14:08

feat: partition db

66264ca

feat: migrate db

b818dea

docs: remove wrong docs

0164cdf

chore: generate and format

efed6f4

fix: proto

e1f5516

initial gateway cli

9bb44c3

initial gateway mocked services

c75007b

changes

ac48596

changes

4a64958

changes

c895d89

changes

2845d01

Flo4604 and others added 7 commits August 5, 2025 18:44

changes

a1b79d6

add latency

6b7e79a

add 502 html

1fb5ec9

remove unneeded file

7f3d201

add todo file

4c85601

refactor: remove seedgateway and hook partitionDB into ctrl

1593dab

fix: import and add missing cmd

63b01b5

vercel bot deployed to Preview – engineering August 6, 2025 14:04 View deployment

vercel bot deployed to Preview – dashboard August 6, 2025 14:05 View deployment

Flo4604 added 4 commits August 6, 2025 16:55

add tls setup for domain

8b8097c

Merge branch 'feat_gateway' of github.com:unkeyed/unkey into feat_gat…

fa73ed1

…eway

add error handling

789c6dc

Merge branch 'main' into feat_gateway

71091c2

vercel bot deployed to Preview – dashboard August 6, 2025 16:24 View deployment

Flo4604 added 2 commits August 7, 2025 12:34

changes

d6bda66

add healtcheck

45d3b51

Flo4604 added 2 commits August 26, 2025 11:34

add some more stuff for letsencrypt

2a9cabd

fmt

67ff2d9

vercel bot deployed to Preview – dashboard August 26, 2025 09:41 View deployment

Flo4604 added 2 commits August 26, 2025 11:57

more changes

12aa88b

more changes

073d788

chronark reviewed Aug 26, 2025

View reviewed changes

go/apps/ctrl/services/acme/certificate_verification.go Show resolved Hide resolved

coderabbitai bot mentioned this pull request Aug 26, 2025

Add caching to certificate verification domain lookup #3855

Open

chronark reviewed Aug 26, 2025

View reviewed changes

Flo4604 commented Aug 26, 2025

View reviewed changes

remove not needed file

d68174c

Flo4604 commented Aug 26, 2025

View reviewed changes

Flo4604 added 5 commits August 26, 2025 22:41

remove some old gw config

14f709e

use some asserts

7f54b32

unify extractHostname func

ba3e5d1

Merge branch 'main' into feat_gateway

2392802

remove some logs

c6faf52

vercel bot deployed to Preview – engineering August 26, 2025 21:19 View deployment

Flo4604 added 2 commits August 27, 2025 17:17

fix missing file

98710a1

fix: store correct cert

843396a

vercel bot deployed to Preview – dashboard August 27, 2025 16:56 View deployment

Flo4604 added 3 commits August 27, 2025 19:45

idk

fa67750

fix: hydra rollback err

4e590db

only use default domain if found

1dfd69e


		import "google/protobuf/timestamp.proto";

		message HandleCertificateVerificationRequest {

feat: WIP WIP WIP gateway #3732

Are you sure you want to change the base?

feat: WIP WIP WIP gateway #3732

Conversation

Flo4604 commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Uh oh!

vercel bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

changeset-bot bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Flo4604 commented Aug 27, 2025

Uh oh!

coderabbitai bot commented Aug 27, 2025

Uh oh!

Flo4604 commented Aug 27, 2025

Uh oh!

coderabbitai bot commented Aug 27, 2025

Uh oh!

Uh oh!

Flo4604 commented Aug 5, 2025 •

edited

Loading

vercel bot commented Aug 5, 2025 •

edited

Loading

coderabbitai bot commented Aug 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

changeset-bot bot commented Aug 5, 2025 •

edited

Loading