fix: improve types for $resolve function
#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you remember what was blocker @danielroe ? |
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 88.08% 88.14% +0.06%
==========================================
Files 8 8
Lines 1175 1181 +6
Branches 272 272
==========================================
+ Hits 1035 1041 +6
Misses 140 140
|
danielroe
changed the title
JSValue in preference to any$resolve function
|
I think this is good to go, but it will of course flag up the need to validate incoming (Or maybe we could consider built-in utils for validating?) |
pi0
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nuxt/nuxt#21295