FormulaOnsets

[behinger]

this was fun, even though specificatio is a bit ugly (similar to the components interface issue, one always has to specify formula and betas separately...)

In any case, I was wondering if we should point the implementation of UniformOnset to the FormulaUniformOnset and simply use an intercept-only 0~1 formula.

But on the flip case, I benchmarked it, and it is significantly slower (makes sense, we have to generate a huge designmatrix first).

Difference is 127µs vs. 32ms...

Probably best to keep both for now?

[codecov]

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 70.32%. Comparing base (5b65d98) to head (41d7306).

Files	Patch %	Lines
src/onset.jl	0.00%	14 Missing ⚠️
src/component.jl	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   72.82%   70.32%   -2.51%     
==========================================
  Files          10       10              
  Lines         357      374      +17     
==========================================
+ Hits          260      263       +3     
- Misses         97      111      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

	# Voila - the inter-onset intervals are `20` samples longer for condition `B`, exactly as specified.`
	# Voila - the inter-onset intervals are `20` samples longer for condition `B`, exactly as specified.`

[github-actions]

[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change