Skip to content

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 23, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improve link-checking CI reliability by fixing the file exclusion pattern in the links workflow. βœ…

πŸ“Š Key Changes

  • Updated lychee link checker --exclude-path from **/ci.yaml to ./**/ci.yaml in two jobs of .github/workflows/links.yml.

🎯 Purpose & Impact

  • Ensures all ci.yaml files are properly excluded from link checks, reducing false positives and unnecessary CI failures. πŸ”§
  • Leads to more stable and predictable CI runs with no impact on end-user features or model performance. πŸš€
  • Internal maintenance only; no changes required from users. πŸ™Œ

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Aug 23, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolov5 πŸš€ PR! This is an automated response; an Ultralytics engineer will review and assist soon. To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolov5 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

Notes for this PR:

  • Thanks for the CI-focused improvement to .github/workflows/links.yml πŸ™Œ
  • Please confirm the updated --exclude-path './**/ci.yaml' behaves as intended across all affected jobs and that link-check runs are green βœ…

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! πŸš€

@glenn-jocher glenn-jocher merged commit 6f603b8 into master Aug 23, 2025
10 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch August 23, 2025 08:48
@UltralyticsAssistant
Copy link
Member

Fantastic work, and great to see this merged! @glenn-jocher, thanks for sharpening our toolingβ€”β€œGive me six hours to chop down a tree, and I will spend the first four sharpening the axe.” β€”Abraham Lincoln. Updating the lychee --exclude-path to ./**/ci.yaml tightens our link checks, reduces false positives, and makes CI more predictable. Small change, big reliability win. Appreciate the attention to detail and the steady push for smoother workflows!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants