Skip to content

Conversation

fatelei
Copy link

@fatelei fatelei commented Nov 16, 2024

fix #268

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2024

CLA assistant check
All committers have signed the CLA.

@ccoVeille
Copy link

No unit test? 😱🤔

@fatelei
Copy link
Author

fatelei commented Nov 16, 2024

No unit test? 😱🤔

i haven't find where to add ut

@ccoVeille
Copy link

Let's wait for a maintainer.

But good thing you took this issue

@ccoVeille
Copy link

@fatelei
Copy link
Author

fatelei commented Nov 16, 2024

As it's about slice, I would say here maybe

https://github.com/uber-go/nilaway/blob/main/testdata%2Fsrc%2Fgo.uber.org%2Fslices%2Fslices.go

ok, i will check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine tracking of slicing index
3 participants