Update tsconfig and corresponding docs #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our generated blueprint was *years* out of date, and between the changes we made in the types over the last year or so and the guidance we have given in the TS RFCs we are now both *able* and *required* to set `strict: true` as well as to opt into `noUncheckedIndexedAccess` and to disable `allowSyntheticDefaultImports` and `esModuleInterop`. Additionally, this provided a nice opportunity to document the choices we have made so folks have something to latch onto when looking at the config we generate for them, and to update the config to target the current latest versions of the `target` and `module` fields.
chriskrycho
force-pushed
the
update-tsconfig
branch
from
6e0a767 to
3271c7b
Compare
NullVoxPopuli
approved these changes
Mar 3, 2022
Collaborator
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Thanks for adding all the context/comments! <3
dfreeman
reviewed
Mar 3, 2022
Comment on lines
+56
to
59
| "declaration": true, | ||
| "declarationMap": true, | ||
| "inlineSourceMap": true, | ||
| "inlineSources": true, |
Member
There was a problem hiding this comment.
Given that we set noEmit: true here and use Babel for actually emitting code, do these flags have any effect?
Member
Author
There was a problem hiding this comment.
I don't actually know! These are what I added four years ago. 😬
| "allowJs": true, | ||
| "target": "ES2022", | ||
| "module": "ES2022", | ||
| "moduleResolution": "node", |
Member
There was a problem hiding this comment.
Not actionable yet, but I suspect we're going to want to change this to node12 as soon as that graduates from nightly, since Webpack 5 (and so by extension, ember-auto-import and Embroider) honor exports config.
Member
Author
There was a problem hiding this comment.
Yep. Hoping they ship that in 4.7 and we can flip it on. 🤞🏼
Co-authored-by: Dan Freeman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our generated blueprint was years out of date, and between the changes we made in the types over the last year or so and the guidance we have given in the TS RFCs we are now both able and required to set
strict: trueas well as to opt intonoUncheckedIndexedAccessand to disableallowSyntheticDefaultImportsandesModuleInterop.Additionally, this provided a nice opportunity to document the choices we have made so folks have something to latch onto when looking at the config we generate for them, and to update the config to target the current latest versions of the
targetandmodulefields.