docs: Fix typos in the Ember Routes docs #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitKrystan
force-pushed
the
fix-resolved-typo
branch
from
c5c39af to
48b1edb
Compare
1. Add a space between "lifecycle" and "hooks"
2. Fix syntax error in `Resolved` type
(and use the same type definition as shown in the cookbook for consistency)
gitKrystan
force-pushed
the
fix-resolved-typo
branch
from
48b1edb to
48b9cb3
Compare
chriskrycho
approved these changes
Jan 31, 2021
Member
chriskrycho
left a comment
chriskrycho
left a comment
There was a problem hiding this comment.
Thanks so much for these!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! I noticed some typos in the Ember Routes docs. This PR will:
Resolvedtype (and use the same type definition as shown in the cookbook for consistency).