[bug] - typescript blueprints do not respect addon ordering

[mike-north]

Please paste the output of ember -v here

ember-cli: 3.5.0-beta.1
node: 8.11.4
os: darwin x64

What are instructions we can follow to reproduce the issue?

Setup

ember new sample; cd ./sample # Create a new ember app
ember install ember-cli-typescript # Set up typescript support
ember install ember-qunit-decorators

Repro

Run ember g component-test x-foo

Now about that bug. What did you expect to see?

Because of the addon order, I'd expect to see the code generated by ember-qunit-decorators.

What happened instead?

I see the code generated by ember-cli-typescript-blueprints

---

This problem is due to the fact that we do not respect addon ordering when inserting ember-cli-typescript-blueprints into the discovered addons array

ember-cli-typescript/ts/addon.js

Lines 30 to 32 in c0bc3d7

	if (this.project.addons.includes(this)) {
	this.project.addons.push(this.addons.find(addon => addon.name === 'ember-cli-typescript-blueprints'));
	}

The code as it currently stands, will result in the e-cli-ts-blueprints code generation winning out over all other addons.

We should probably find the index of ember-cli-typescript in the array, and splice the blueprints in immediately after it.

[jamescdavis]

I think this is why this happening: https://github.com/typed-ember/ember-cli-typescript-blueprints/blob/master/package.json#L75
Both are asking to run after ember-decorators and somehow the three-way interaction is causing ember-cli-typescript-blueprints to win over ember-qunit-decorators (not sure how ember-cli decides this, though).

[mike-north]

@jamescdavis to be clear -- after does not mean immediately after. There's no conflict here -- both addons run at some point after e-cli-decorators has run

[jamescdavis]

I originally misread and thought ember-cli-typescript-blueprints was saying after ember-qunit-decorators, but it's just saying after ember-decorators. Sorry to add to the confusion. I still think something weird is going on with the way the addons order specifications are interacting.