Remove shipped certs #376
Merged
Remove shipped certs #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougblack
approved these changes
Jul 14, 2017
dougblack
approved these changes
Jul 14, 2017
|
Don't we still need to provide the path to the CA Bundle even if we use the certifi package. We would need the get_cert_file logic to change to... import certifi |
|
From my understanding of https://github.com/requests/requests/blob/master/requests/adapters.py#L221 and https://github.com/requests/requests/blob/master/requests/utils.py#L39, I think requests will do this automatically. |
|
Ok. It would be good to verify that behavior. Not sure why our simple test was giving us a warning then. |
|
@jingming If you can resolve the conflicts, I think we can mark this as [deploy], yes? |
|
@jmctwilio conflicts resolved. |
andersk
added a commit
to andersk/twilio-python
that referenced
this pull request
Mar 19, 2025
Commit d75a66b (twilio#376) should have removed this. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/twilio-python
that referenced
this pull request
Mar 19, 2025
Commit d75a66b (twilio#376) should have removed this. Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.