Fix: Resolve plots directory path inconsistency in GenAI-perf #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nv-hwoo @dyastremsky @matthewkotila Can you help review this? |
|
I also noticed this issue. Current code only needs to create plot config one time, but your code will cause configs to be generated several times. I am not sure whether this is good. |
When using model names with special characters (e.g., paths with slashes), GenAI-perf creates sanitized artifact directory names but the plots generation fails due to path mismatches between profile() and create_plots() methods. - Fixed create_plots() to use the same PerfAnalyzerConfig path logic as profile() - Ensured plots directory is created under the correct sanitized artifact directory - Added proper path resolution for profile_export_file in plots configuration This resolves the "No such file or directory: 'artifacts/plots/config.yaml'" error fundamentally.
…ingle-run behavior - Cache objectives, GenAIPerfConfig, and PerfAnalyzerConfig in Profile.__init__ to keep a consistent run context across profiling and plotting - Update profile() to reuse cached configs instead of reconstructing them - Use PerfAnalyzerConfig.get_artifact_directory() and get_profile_export_file() in create_plots() to avoid global output paths that caused repeated handling across runs - Improves determinism and prevents unintended multi-run plot generation - Refs TMA-1911 Signed-off-by: Rythsman <[email protected]>
Rythsman
force-pushed
the
fix_generate-plots_bug
branch
from
a3e3221 to
40dd643
Compare
@ExplorerRay i see, i have modified to make create plot config only one time |
|
@nv-hwoo @dyastremsky @matthewkotila Can anyone help review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using model names with special characters (e.g., paths with slashes), GenAI-perf creates sanitized artifact directory names but the plots generation fails due to path mismatches between profile() and create_plots() methods.
This resolves the "No such file or directory: 'artifacts/plots/config.yaml'" error fundamentally.