Avoid double free the global onnxloader when system exit #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue to fix:
The static OnnxLoader::loader object may be destroyed by the system before the customer's cleanup code (e.g., TRITONSERVER_ServerDelete) runs.
This premature destruction causes an assertion failure inside ONNX Runtime initially. Even if the assertion is suppressed, it leads to double-free errors detected by the system during shutdown.
Proposed solution:
Modify the OnnxLoader destructor to explicitly set the internal pointer to nullptr.
This ensures that subsequent null checks on loader in UnloadSession and Stop methods function correctly, preventing use-after-free or double-free issues.