Skip to content

Conversation

anshul-goyal-t
Copy link

No description provided.

Dockerfile Outdated
RUN pip install -r requirements.txt
# Copy your codebase into the Docker container.

#COPY ./ /code/AnshulGoyal-jtu-22-assignment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid pushing commented code.
Although, copying requirements.txt and running pip install before copying the codebase is a good idea (refer). Your directory structure was a bit messed up though, that's why it probably didn't work. You should try copying requirements to /AnshulGoyal-jtu-22-assignment/requirements.txt, and copy your codebase to /AnshulGoyal-jtu-22-assignment (you don't have a /code folder in your Docker container, so it doesn't make sense to reference it).

Copy link
Contributor

@shubhankar-ti shubhankar-ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Dockerfile seems good; you're installing requirements correctly now. However, you've pushed the __pycache__ folder to your repo, which is an IDE-specific folder. You should avoid pushing such folders to your repo. You should remove it, and ideally add a .gitignore file that makes git ignore this folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants