-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
task: improve the example of poll_proceed
#7586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: improve the example of poll_proceed
#7586
Conversation
Signed-off-by: ADD-SP <[email protected]>
7f9ff77 to
016a574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good example, thanks.
Signed-off-by: ADD-SP <[email protected]>
|
Actually, I'm not so sure about the example. The branch returns |
Signed-off-by: ADD-SP <[email protected]>
Ah, bad mistake, I have fixed it. |
|
I considered adding a reasonable |
|
What about having the example be "add coop to the futures mpsc channel"? |
Signed-off-by: ADD-SP <[email protected]>
Signed-off-by: ADD-SP <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit. Feel free to merge after this.
Signed-off-by: ADD-SP <[email protected]>

Motivation
I noticed the example of
poll_proceedis a bit long while thinking about the #7565 (comment).I always prefer a short example because it helps people like me to grasp the basic usage in 10 seconds.