Skip to content

WebGPURenderer: Improve ArrayCamera performance and fixes #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 21, 2025
Merged

WebGPURenderer: Improve ArrayCamera performance and fixes #1509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f03f7a
WebGPURenderer: Improve ArrayCamera performance and fixes
Methuselah96 Jan 21, 2025
d428984
Update three.js
Methuselah96 Jan 21, 2025
57326c8
Add src
Methuselah96 Jan 21, 2025
8d82165
Update patch and delete src
Methuselah96 Jan 21, 2025
022091c
Update declarations
Methuselah96 Jan 21, 2025
e9409be
Add examples
Methuselah96 Jan 21, 2025
73a40dc
Update
Methuselah96 Jan 21, 2025
cd970e5
Update patch and delete examples
Methuselah96 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions examples-testing/changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13336,27 +13336,33 @@ index 45619da3..97df59b3 100644
case 79 /*O*/:
activeCamera = cameraOrtho;
diff --git a/examples-testing/examples/webgpu_camera_array.ts b/examples-testing/examples/webgpu_camera_array.ts
index 2e8218be..92051ebc 100644
index 919b7422..fb696689 100644
--- a/examples-testing/examples/webgpu_camera_array.ts
+++ b/examples-testing/examples/webgpu_camera_array.ts
@@ -1,6 +1,6 @@
@@ -1,10 +1,10 @@
-import * as THREE from 'three';
+import * as THREE from 'three/webgpu';

import Stats from 'three/addons/libs/stats.module.js';

-let camera, scene, renderer;
-let mesh;
-let stats;
+let camera: THREE.ArrayCamera, scene: THREE.Scene, renderer: THREE.WebGPURenderer;
let mesh;
+let mesh: THREE.Mesh;
+let stats: Stats;

const AMOUNT = 6;

@@ -87,7 +87,7 @@ function onWindowResize() {
for (let x = 0; x < AMOUNT; x++) {
@@ -82,7 +82,7 @@ function updateCameras() {
const subcamera = camera.cameras[AMOUNT * y + x];
subcamera.copy(camera); // copy fov, aspect ratio, near, far from the root camera

- subcamera.viewport.set(Math.floor(x * WIDTH), Math.floor(y * HEIGHT), Math.ceil(WIDTH), Math.ceil(HEIGHT));
+ subcamera.viewport!.set(Math.floor(x * WIDTH), Math.floor(y * HEIGHT), Math.ceil(WIDTH), Math.ceil(HEIGHT));

subcamera.aspect = ASPECT_RATIO;
subcamera.updateProjectionMatrix();

subcamera.position.x = x / AMOUNT - 0.5;
diff --git a/examples-testing/examples/webgpu_camera_logarithmicdepthbuffer.ts b/examples-testing/examples/webgpu_camera_logarithmicdepthbuffer.ts
index 15527632..58f5cc14 100644
--- a/examples-testing/examples/webgpu_camera_logarithmicdepthbuffer.ts
Expand Down Expand Up @@ -16975,7 +16981,7 @@ index 45ffecc1..ce082652 100644
});

diff --git a/examples-testing/examples/webgpu_postprocessing_traa.ts b/examples-testing/examples/webgpu_postprocessing_traa.ts
index 9a5558e9..05dbf9db 100644
index 6e8509d1..7540235d 100644
--- a/examples-testing/examples/webgpu_postprocessing_traa.ts
+++ b/examples-testing/examples/webgpu_postprocessing_traa.ts
@@ -1,11 +1,14 @@
Expand Down
Loading
Loading