Skip to content

WebGLRenderer: Add transmission render target scale #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2024
Merged

WebGLRenderer: Add transmission render target scale #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c80e54
WebGLRenderer: Add transmission render target scale
Methuselah96 Dec 15, 2024
ec9a905
Update three.js
Methuselah96 Dec 15, 2024
da35f07
Add examples
Methuselah96 Dec 15, 2024
6e9de3e
Update patch and delete examples
Methuselah96 Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples-testing/changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8437,19 +8437,19 @@ index 408fd992..dc782ea9 100644
init();

diff --git a/examples-testing/examples/webgl_materials_physical_transmission.ts b/examples-testing/examples/webgl_materials_physical_transmission.ts
index d4596797..6464232e 100644
index 08c73894..45b0f9ba 100644
--- a/examples-testing/examples/webgl_materials_physical_transmission.ts
+++ b/examples-testing/examples/webgl_materials_physical_transmission.ts
@@ -19,7 +19,7 @@ const params = {
exposure: 1,
@@ -20,7 +20,7 @@ const params = {
transmissionResolutionScale: 1,
};

-let camera, scene, renderer;
+let camera: THREE.PerspectiveCamera, scene: THREE.Scene, renderer: THREE.WebGLRenderer;

let mesh;

@@ -170,7 +170,7 @@ function generateTexture() {
@@ -178,7 +178,7 @@ function generateTexture() {
canvas.width = 2;
canvas.height = 2;

Expand Down
2 changes: 1 addition & 1 deletion three.js
Open in desktop
Submodule three.js updated 4 files
+3 −3 .github/workflows/codeql-code-scanning.yml
+3 −0 docs/api/en/renderers/WebGLRenderer.html
+11 −1 examples/webgl_materials_physical_transmission.html
+4 −1 src/renderers/WebGLRenderer.js
7 changes: 7 additions & 0 deletions types/three/src/renderers/WebGLRenderer.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,13 @@ export class WebGLRenderer implements Renderer {
*/
toneMappingExposure: number;

/**
* The normalized resolution scale for the transmission render target, measured in percentage of viewport
* dimensions. Lowering this value can result in significant improvements to {@link MeshPhysicalMaterial}
* transmission performance. Default is `1`.
*/
transmissionResolutionScale: number;

info: WebGLInfo;

shadowMap: WebGLShadowMap;
Expand Down
Loading