Skip to content

Conversation

builtbybengt
Copy link
Contributor

@builtbybengt builtbybengt commented Nov 11, 2024

added custom classes and resolve issue (#2)

custom classes:

  • updated handleDragStart and handleDragEnd to remove / add the classes that were given in options.attributes.draggingClass
  • updated handleDragEnter and handleDragLeave to remove / add the classes that were given in options.attributes.dragOverClasses

issue #2:

  • created a target element which is the actual element the user is dragging on
  • checked if the last element that was entered is the current target element

@Spikeysanju Spikeysanju self-requested a review November 12, 2024 17:30
@Spikeysanju Spikeysanju added the enhancement New feature or request label Nov 12, 2024
Copy link
Contributor

@Spikeysanju Spikeysanju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bxnq, thanks for the PR. LGTM. Merging it!

@Spikeysanju Spikeysanju linked an issue Nov 12, 2024 that may be closed by this pull request
@Spikeysanju Spikeysanju merged commit 299c1ec into thisuxhq:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class drag-over isn't removed once added

2 participants